Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[home-assistant] Update common chart to v2.0.0 #500

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

damacus
Copy link

@damacus damacus commented Jan 17, 2024

  • Updated the version of the "common" dependency to 2.4.0
  • Removed unused files common.yaml and NOTES.txt
  • Updated the version of the "common" dependency in Chart.yaml
  • Modified ingress settings for main application and code-server sidecar

@damacus
Copy link
Author

damacus commented Jan 17, 2024

I've removed the Postgresql chart for now. I'll re-add it when we've done a first pass.

This looks similar to bjw's example home-assistant chart. I'm having trouble wrangling helm into loading this example chart so I suspect I've got a value wrong somewhere.

I've also started dropping comments where they no longer make sense. I'm happy to build these back up as pointers.

- Updated the version of the "common" dependency to 2.4.0
- Removed unused files common.yaml and NOTES.txt
- Updated the version of the "common" dependency in Chart.yaml
- Modified ingress settings for main application and code-server sidecar
@gabe565
Copy link
Owner

gabe565 commented Jan 21, 2024

Thank you, this looks great! I love that you also included some addons. Let me test it out :)

@damacus
Copy link
Author

damacus commented Jan 21, 2024

If this works, I can blast through a few more this week. The new format does take a little bit of getting used to (volumes are kind of funky)

@damacus damacus changed the title Update dependencies and versions in home-assistant chart [home-assistant] Update common chart to v2.0.0 Jan 23, 2024
@damacus damacus marked this pull request as ready for review January 23, 2024 11:02
@damacus damacus requested a review from gabe565 as a code owner January 23, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants