Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passport support in fasp.loc.DRSClient base class #1

Open
ianfore opened this issue Jul 28, 2022 · 2 comments
Open

Passport support in fasp.loc.DRSClient base class #1

ianfore opened this issue Jul 28, 2022 · 2 comments

Comments

@ianfore
Copy link
Contributor

ianfore commented Jul 28, 2022

Note differences in how Passport is passed in the two known DRS implementations using Passport

  • SRA DRS - see fasp.loc.SRADRSClient
    Syntax is - {"ga4gh_passport": access_token}
  • GA4GH StarterKit
    See Step 12 here

It is not clear which DRS spec either of these implementations is targeting. Suggest that needs to be addressed before definitive support is provided in the client.

@briandoconnor
Copy link
Contributor

Look at the POST objects here:

https://ga4gh.github.io/data-repository-service-schemas/preview/release/drs-1.2.0/docs/#operation/PostObject

This is spec 1.2 that shows how to post an array of Passports

@ianfore
Copy link
Contributor Author

ianfore commented Jul 28, 2022

Thanks Brian. So StarterKit is coding to the 1.2 spec.
As discussed in call that's what it would make sense to support in the base class. Tagging @vsmalladi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants