Skip to content
This repository has been archived by the owner on Oct 5, 2024. It is now read-only.

Support static labels (without fading) in Pie charts #13

Open
g1eng opened this issue Nov 29, 2021 · 0 comments
Open

Support static labels (without fading) in Pie charts #13

g1eng opened this issue Nov 29, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@g1eng
Copy link
Owner

g1eng commented Nov 29, 2021

Problem

setLabel method in Pie layer cannot parse Layer.label.
So any static label, which is shown by default, cannot be rendered.

In principle, Pie overrides setLabel and it should support the same behavior with other layers.
FigConfig API on display control on static label for Pie charts, should be supported.

Proposal

Implement internal process which parses FigConfig.label in Pie constructor.
Relative field name and its role can be following one:

{
  label: {
    visible: Boolean,  // label visibility control
    rotate: Number,  // label rotation control
    fade: Boolean   // whether its labels is static or not
  }
}
@g1eng g1eng added the bug Something isn't working label Nov 29, 2021
@g1eng g1eng changed the title Support static label (without fade) in Pie charts Support static labels (without fade) in Pie charts Nov 29, 2021
@g1eng g1eng changed the title Support static labels (without fade) in Pie charts Support static labels (without fading) in Pie charts Nov 29, 2021
@g1eng g1eng added enhancement New feature or request and removed bug Something isn't working labels Dec 1, 2021
@g1eng g1eng added this to the v0.2.0 milestone Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant