Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Event table must-could-should #69

Closed
8 of 12 tasks
fyliu opened this issue May 30, 2024 · 0 comments
Closed
8 of 12 tasks

Update Event table must-could-should #69

fyliu opened this issue May 30, 2024 · 0 comments

Comments

@fyliu
Copy link
Owner

fyliu commented May 30, 2024

Overview

We need to update the event table model in django to utilize the practice area table instead of the outdated role table.

Details

The old model issues for this table are

Action Items

  • Update existing Django model
  • Write a test for the new relationships this model will have with other models (e.g., creating a user and assigning them a set of permissions on a project) if any.
  • Update API end point
  • Update API unit tests
  • Document the endpoint in Swagger

Changes Needed

Columns to Remove

  • must_roles - int[] (role_id)
  • should_roles - int[] (role_id)
  • could_roles - int[] (role_id)

Columns to Add

  • must_attend - JSON[]
  • should_attend - JSON[]
  • could_attend - JSON[]

Additional Changes

  • Add example JSON to the documentation (like the one in the ERD)

JSON Example:

[
  {
    practice_area: engineering,
    permission_level: practiceLeadProject
  },
  {
    practice_area: pm,
    permission_level: practiceLeadProject
  }
]

Resources

Practice Areas:

  • Development
  • Project Management
  • Design
  • Professional Development

Permission Types:

  • adminGlobal
  • adminBrigade
  • adminProject
  • practiceLeadProject
  • practiceLeadJrProject
  • memberProject
  • memberGeneral

Test suggestions

  • create an "All" event for the PeopleDepot project with these attendance suggestions
    • must: adminProject, practiceLeadProject, practiceLeadJrProject
    • should: memberProject
    • could: memberGeneral
  • need an example that utilizes Practice Area values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant