You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The example is copied from 716d2e:incl/progress_aggregator.R, but with the wrong amount of steps corrected from 4 to 8 (1: top-level progress(), 2-3: slow_sum(1:2), 4-7: slow_sum(1:4), 8: second progress()`:
Expected result: The progress bar reaches 100% after the progress() call in line 11.
Actual result: The progress bar fills quicky, before the second slow_sum() even starts.
The progress call in slow_sum() is progress(amount = 0) which is captured by the progress aggegator, but that re-emits a progression progress(child = p), omitting the amount= option, which then defaults to 1. In fact, no property of the initial progression condition is relayed. The initial progression is just included as an additional option called child= but I see that is handled nowhere.
The text was updated successfully, but these errors were encountered:
mlell
added a commit
to mlell/progressr
that referenced
this issue
Nov 12, 2021
When the progression condition that is to be relayed was created with
any arguments, they need to be relayed as well when creating a new
progression object in progress_aggregator().
Fixesfutureverse#126.
When the progression condition that is to be relayed was created with
any arguments, they need to be relayed as well when creating a new
progression object in progress_aggregator().
Fixesfutureverse#126.
The example is copied from
716d2e:incl/progress_aggregator.R
, but with the wrong amount of steps corrected from 4 to 8 (1: top-levelprogress()
, 2-3:slow_sum(1:2)
, 4-7:slow_sum(1:4), 8: second
progress()`:Expected result: The progress bar reaches 100% after the
progress()
call in line 11.Actual result: The progress bar fills quicky, before the second
slow_sum()
even starts.Reason: Rows like this in
slow_sum()
https://github.com/HenrikBengtsson/progressr/blob/716d2e750a7667303244f91736f0f8315577e25a/R/slow_sum.R#L24
...together with this line in
R/progress_aggregator.R
:https://github.com/HenrikBengtsson/progressr/blob/716d2e750a7667303244f91736f0f8315577e25a/R/progress_aggregator.R#L34
The progress call in
slow_sum()
isprogress(amount = 0)
which is captured by the progress aggegator, but that re-emits a progressionprogress(child = p)
, omitting theamount=
option, which then defaults to 1. In fact, no property of the initial progression condition is relayed. The initial progression is just included as an additional option calledchild=
but I see that is handled nowhere.The text was updated successfully, but these errors were encountered: