Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast addrerss is not being set correctly for /26 netmask #40

Open
jmcc94 opened this issue Apr 23, 2022 · 0 comments · May be fixed by #41
Open

Broadcast addrerss is not being set correctly for /26 netmask #40

jmcc94 opened this issue Apr 23, 2022 · 0 comments · May be fixed by #41

Comments

@jmcc94
Copy link

jmcc94 commented Apr 23, 2022

I have a network with a netmask of 255.255.255.192, and it seems as though the broadcast address isn't being set correctly.

Stepping though the code, it looks like my broadcast address is being set to the same address as my local IP - and so no discovery is working...
jmcc94 added a commit to jmcc94/node-lifx-lan that referenced this issue Apr 23, 2022
@jmcc94
Update lifx-lan-address.js
b800368 
Added bitwise operation to _getBroadcastAddress to return correct broadcast addresses for all netmasks. 

Fixes futomi#40
@jmcc94 jmcc94 linked a pull request Apr 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update lifx-lan-address.js jmcc94/node-lifx-lan
1 participant
@jmcc94