Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageViewer is broken #27

Open
1 of 3 tasks
sebbert opened this issue Sep 30, 2016 · 5 comments
Open
1 of 3 tasks

ImageViewer is broken #27

sebbert opened this issue Sep 30, 2016 · 5 comments
Assignees
Labels

Comments

@sebbert
Copy link
Contributor

sebbert commented Sep 30, 2016

ImageViewer has a couple of bugs that I don't have the knowledge of how to fix.

  • - Double tapping to reset the transform and the close button works only while interacting with the Rotate- Zoom- and RotateGestures.
  • - Rotation gesture often wraps around, resulting in a rotation > 180°, instead of taking the shortest path.
  • - A bunch of TODO comments and confusion regarding removed/renamed/deprecated features

Tested using Android preview, Fuse 0.26.0 (7741)

@bondehagen
Copy link
Contributor

The gestures also feals very unnatural and weird.

@bondehagen
Copy link
Contributor

@sebbert some of this is fixed in 7a78a08#diff-76f439ed0cffc2d7d6091816c835f426

@bondehagen
Copy link
Contributor

bondehagen commented May 8, 2017

Switching from portrait to landscape is messing up the layout when viewing an image

@kristianhasselknippe
Copy link
Member

@eksperts will take a look at this today

@eksperts
Copy link
Contributor

eksperts commented May 9, 2017

@bondehagen PR in: #59
First it's a general syntax cleanup and associated changes to match best practices.
Second, the RotateGesture wrap-around problem was caused by the StepDegrees property; removed it and it's now fine (tried, but could not find a way to eliminate wrap-around by leaving StepDegrees).
Could not reproduce the "double tapping" issue @sebbert mentioned, worked fine on a Nexus 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants