From 91d1c5062edcec12706ea0fd37168ca595823e03 Mon Sep 17 00:00:00 2001
From: furkanaskin <seeingisknow@gmail.com>
Date: Tue, 15 Sep 2020 22:27:30 +0300
Subject: [PATCH] Code improvements

---
 .idea/codeStyles/Project.xml                  | 15 ++-----
 .../faskn/clickablepiechart/MainActivity.kt   |  8 ++--
 app/src/main/res/layout/activity_main.xml     |  8 ++--
 .../java/com/faskn/lib/ClickablePieChart.kt   | 39 ++++++++++++-------
 .../main/java/com/faskn/lib/PieChartDsl.kt    | 32 +++++++--------
 lib/src/main/java/com/faskn/lib/Slice.kt      |  7 +++-
 .../main/res/drawable/circle_indicator.xml    |  2 +-
 lib/src/main/res/layout/layout_info.xml       | 37 ------------------
 lib/src/main/res/values/attrs.xml             |  4 +-
 9 files changed, 59 insertions(+), 93 deletions(-)
 delete mode 100644 lib/src/main/res/layout/layout_info.xml

diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml
index 3cc336b..7a748e4 100644
--- a/.idea/codeStyles/Project.xml
+++ b/.idea/codeStyles/Project.xml
@@ -3,18 +3,9 @@
     <JetCodeStyleSettings>
       <option name="PACKAGES_TO_USE_STAR_IMPORTS">
         <value>
-          <package name="java.util" alias="false" withSubpackages="false" />
-          <package name="kotlinx.android.synthetic" alias="false" withSubpackages="true" />
-          <package name="io.ktor" alias="false" withSubpackages="true" />
-        </value>
-      </option>
-      <option name="PACKAGES_IMPORT_LAYOUT">
-        <value>
-          <package name="" alias="false" withSubpackages="true" />
-          <package name="java" alias="false" withSubpackages="true" />
-          <package name="javax" alias="false" withSubpackages="true" />
-          <package name="kotlin" alias="false" withSubpackages="true" />
-          <package name="" alias="true" withSubpackages="true" />
+          <package name="java.util" withSubpackages="false" static="false" />
+          <package name="kotlinx.android.synthetic" withSubpackages="true" static="false" />
+          <package name="io.ktor" withSubpackages="true" static="false" />
         </value>
       </option>
       <option name="CODE_STYLE_DEFAULTS" value="KOTLIN_OFFICIAL" />
diff --git a/app/src/main/java/com/faskn/clickablepiechart/MainActivity.kt b/app/src/main/java/com/faskn/clickablepiechart/MainActivity.kt
index 4b6009b..aa25def 100644
--- a/app/src/main/java/com/faskn/clickablepiechart/MainActivity.kt
+++ b/app/src/main/java/com/faskn/clickablepiechart/MainActivity.kt
@@ -4,7 +4,7 @@ import android.os.Bundle
 import android.util.Log
 import androidx.appcompat.app.AppCompatActivity
 import com.faskn.lib.Slice
-import com.faskn.lib.pieChart
+import com.faskn.lib.buildChart
 import kotlinx.android.synthetic.main.activity_main.*
 import kotlin.random.Random
 
@@ -12,19 +12,17 @@ class MainActivity : AppCompatActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_main)
-        chart.setCenterColor(R.color.white)
 
         // Kotlin DSL example
-        val pieChart1 = pieChart {
+        val pieChart1 = buildChart {
             slices {
-                arrayOf(
+                arrayListOf(
                     Slice(Random.nextInt(1000, 3000).toFloat(), R.color.colorPrimary),
                     Slice(Random.nextInt(1000, 2000).toFloat(), R.color.colorPrimaryDark),
                     Slice(Random.nextInt(1000, 5000).toFloat(), R.color.materialIndigo600),
                     Slice(Random.nextInt(1000, 10000).toFloat(), R.color.colorAccent)
                 )
             }
-
             sliceWidth { 80f }
             sliceStartPoint { 0f }
             clickListener { s, fl ->
diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml
index c28dce3..895bdc5 100644
--- a/app/src/main/res/layout/activity_main.xml
+++ b/app/src/main/res/layout/activity_main.xml
@@ -1,15 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    xmlns:app="http://schemas.android.com/apk/res-auto"
     tools:context=".MainActivity">
 
     <com.faskn.lib.ClickablePieChart
         android:id="@+id/chart"
         android:layout_width="250dp"
-        app:popupText="Ziyaret"
+        android:layout_height="250dp"
         android:layout_centerInParent="true"
-        android:layout_height="250dp" />
+        app:centerColor="@color/white"
+        app:popupText="Ziyaret"
+        app:showPopup="true" />
 </RelativeLayout>
\ No newline at end of file
diff --git a/lib/src/main/java/com/faskn/lib/ClickablePieChart.kt b/lib/src/main/java/com/faskn/lib/ClickablePieChart.kt
index 6143695..b4dff6c 100644
--- a/lib/src/main/java/com/faskn/lib/ClickablePieChart.kt
+++ b/lib/src/main/java/com/faskn/lib/ClickablePieChart.kt
@@ -27,26 +27,29 @@ import kotlin.math.atan2
 import kotlin.math.cos
 import kotlin.math.sin
 
-
 class ClickablePieChart @JvmOverloads constructor(
     context: Context,
-    private val attrs: AttributeSet? = null,
+    attrs: AttributeSet? = null,
     defStyleAttr: Int = 0
 ) : View(context, attrs, defStyleAttr) {
 
     private var slicePaint: Paint = Paint()
-    private var centerPaint: Paint = Paint(Paint.ANTI_ALIAS_FLAG)
+    private var centerPaint: Paint = Paint(Paint.ANTI_ALIAS_FLAG).apply {
+        color = Color.WHITE
+        style = Paint.Style.FILL
+    }
     private var rectF: RectF? = null
     private var touchX = 0f
     private var touchY = 0f
 
     // PieChart variables
     private var pieChart: PieChart? = null
-    private var slices: Array<Slice>? = null
+    private var slices: ArrayList<Slice>? = null
 
     // Animation variables
     private var animator: ValueAnimator? = null
     private var currentSweepAngle = 0
+    private var showPopup = true
 
     // Attributes
     private var popupText: String? = null
@@ -60,9 +63,6 @@ class ClickablePieChart @JvmOverloads constructor(
         slicePaint.isDither = true
         slicePaint.style = Paint.Style.FILL
 
-        centerPaint.color = Color.WHITE
-        centerPaint.style = Paint.Style.FILL
-
         initSlices()
         startAnimation()
     }
@@ -73,6 +73,11 @@ class ClickablePieChart @JvmOverloads constructor(
 
         try {
             popupText = typedArray.getString(R.styleable.ClickablePieChart_popupText) ?: ""
+            centerPaint.color = typedArray.getColor(
+                R.styleable.ClickablePieChart_centerColor,
+                ContextCompat.getColor(context, android.R.color.white)
+            )
+            showPopup = typedArray.getBoolean(R.styleable.ClickablePieChart_showPopup, true)
         } finally {
             typedArray.recycle()
         }
@@ -182,16 +187,16 @@ class ClickablePieChart @JvmOverloads constructor(
                 }
 
                 var total = 0.0f
-                var forEachStopper = false // what a idiot stuff
-                slices?.forEachIndexed { index, slice ->
-                    total += (slice.scaledValue ?: 0f) % 360f
-                    if (touchAngle <= total && !forEachStopper) {
-                        pieChart?.clickListener?.invoke(touchAngle.toString(), index.toFloat())
-                        forEachStopper = true
-                        showInfoPopup(index)
+                run {
+                    slices?.forEachIndexed { index, slice ->
+                        total += (slice.scaledValue ?: 0f) % 360f
+                        if (touchAngle <= total && showPopup) {
+                            pieChart?.clickListener?.invoke(touchAngle.toString(), index.toFloat())
+                            showInfoPopup(index)
+                            return@run
+                        }
                     }
                 }
-                forEachStopper = false
                 true
             }
             else -> false
@@ -262,6 +267,10 @@ class ClickablePieChart @JvmOverloads constructor(
         invalidateAndRequestLayout()
     }
 
+    fun setShowPopup(show: Boolean) {
+        showPopup = show
+    }
+
     private fun invalidateAndRequestLayout() {
         invalidate()
         requestLayout()
diff --git a/lib/src/main/java/com/faskn/lib/PieChartDsl.kt b/lib/src/main/java/com/faskn/lib/PieChartDsl.kt
index 8bef0d9..9ac92b8 100644
--- a/lib/src/main/java/com/faskn/lib/PieChartDsl.kt
+++ b/lib/src/main/java/com/faskn/lib/PieChartDsl.kt
@@ -7,22 +7,22 @@ package com.faskn.lib
 @DslMarker
 annotation class PieChartDsl
 data class PieChart(
-    var slices: Array<Slice>?,
+    var slices: ArrayList<Slice>,
     var clickListener: ((String, Float) -> Unit)?,
     var sliceStartPoint: Float?,
     var sliceWidth: Float?
 )
 
-fun pieChart(block: PieChartBuilder.() -> Unit) = PieChartBuilder().apply(block).build()
+fun buildChart(block: PieChartBuilder.() -> Unit) = PieChartBuilder().apply(block).build()
 
 @PieChartDsl
 class PieChartBuilder {
-    private var slices: Array<Slice>? = null
+    private lateinit var slices: ArrayList<Slice>
     private var clickListener: ((String, Float) -> Unit)? = null
     private var sliceStartPoint = 0f
     private var sliceWidth = 80f
 
-    fun slices(block: () -> Array<Slice>) {
+    fun slices(block: () -> ArrayList<Slice>) {
         slices = block()
     }
 
@@ -44,23 +44,21 @@ class PieChartBuilder {
     }
 
     private fun initScaledArcs() {
-        if (slices != null) {
-            slices?.forEachIndexed { i, slice ->
-                val scaledValue = (slice.dataPoint / getSumOfDataPoints()) * 360
-                slice.scaledValue = scaledValue
-                if (i != 0) {
-                    slice.arc = Arc(
-                        slices!![i - 1].arc?.sweepAngle!!,
-                        slices!![i - 1].arc?.sweepAngle!!.plus(scaledValue)
-                    )
-                } else {
-                    slice.arc = Arc(0f, scaledValue)
-                }
+        slices.forEachIndexed { i, slice ->
+            val scaledValue = (slice.dataPoint / getSumOfDataPoints()) * 360
+            slice.scaledValue = scaledValue
+            if (i != 0) {
+                slice.arc = Arc(
+                    slices[i - 1].arc?.sweepAngle!!,
+                    slices[i - 1].arc?.sweepAngle!!.plus(scaledValue)
+                )
+            } else {
+                slice.arc = Arc(0f, scaledValue)
             }
         }
     }
 
     private fun getSumOfDataPoints(): Float {
-        return slices?.sumByDouble { slice -> slice.dataPoint.toDouble() }?.toFloat() ?: 0f
+        return slices.sumByDouble { slice -> slice.dataPoint.toDouble() }.toFloat()
     }
 }
\ No newline at end of file
diff --git a/lib/src/main/java/com/faskn/lib/Slice.kt b/lib/src/main/java/com/faskn/lib/Slice.kt
index 513e147..d9fcd48 100644
--- a/lib/src/main/java/com/faskn/lib/Slice.kt
+++ b/lib/src/main/java/com/faskn/lib/Slice.kt
@@ -1,14 +1,17 @@
 package com.faskn.lib
 
+import androidx.annotation.ColorRes
+import androidx.annotation.Px
+
 /**
  * Created by turkergoksu on 12-Aug-20
  */
 
 data class Slice(
     val dataPoint: Float,
-    val color: Int,
+    @ColorRes val color: Int,
     var arc: Arc? = null,
-    var scaledValue: Float? = 0f
+    @Px var scaledValue: Float? = 0f
 )
 
 data class Arc(
diff --git a/lib/src/main/res/drawable/circle_indicator.xml b/lib/src/main/res/drawable/circle_indicator.xml
index e41b27a..623a1d3 100644
--- a/lib/src/main/res/drawable/circle_indicator.xml
+++ b/lib/src/main/res/drawable/circle_indicator.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
     android:shape="oval">
-    <solid android:color="@android:color/black" />
+    <solid android:color="@android:color/holo_red_dark" />
     <size
         android:width="8dp"
         android:height="8dp" />
diff --git a/lib/src/main/res/layout/layout_info.xml b/lib/src/main/res/layout/layout_info.xml
deleted file mode 100644
index df371f1..0000000
--- a/lib/src/main/res/layout/layout_info.xml
+++ /dev/null
@@ -1,37 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:app="http://schemas.android.com/apk/res-auto"
-    xmlns:tools="http://schemas.android.com/tools"
-    android:id="@+id/rootView"
-    android:layout_width="wrap_content"
-    android:layout_height="wrap_content"
-    android:background="@android:color/black"
-    android:orientation="vertical">
-
-    <androidx.cardview.widget.CardView
-        android:id="@+id/cardView"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        app:cardBackgroundColor="@android:color/black"
-        app:cardCornerRadius="4dp"
-        app:cardElevation="4dp">
-
-        <TextView
-            android:id="@+id/textViewInfo"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_margin="4dp"
-            android:textColor="@android:color/white"
-            android:textSize="12sp"
-            tools:text="Some info text" />
-    </androidx.cardview.widget.CardView>
-    <!--
-        <ImageView
-            android:id="@+id/imageViewArrow"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_centerHorizontal="true"
-            android:adjustViewBounds="true"
-            android:rotation="180"
-            android:src="@drawable/ic_arrow_down_" />-->
-</RelativeLayout>
\ No newline at end of file
diff --git a/lib/src/main/res/values/attrs.xml b/lib/src/main/res/values/attrs.xml
index 7d266c3..bc3e783 100644
--- a/lib/src/main/res/values/attrs.xml
+++ b/lib/src/main/res/values/attrs.xml
@@ -1,6 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
     <declare-styleable name="ClickablePieChart">
-        <attr name="popupText" format="string"/>
+        <attr name="popupText" format="string" />
+        <attr name="centerColor" format="color" />
+        <attr name="showPopup" format="boolean" />
     </declare-styleable>
 </resources>
\ No newline at end of file