New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeerDependency `@ember/string` is missing #380

Open

mkszepp opened this issue Aug 6, 2024 · 0 comments

mkszepp commented Aug 6, 2024 •

edited

Loading

The addon is using @ember/string but its not declared as peerDependency.

This makes impossible to use @ember/string v4 as its a v2 addon

ember-local-storage/addon/helpers/storage.js

Lines 1 to 8 in 02112d1

    
           import { assert } from '@ember/debug'; 
        
           import EmberObject, { computed, get } from '@ember/object'; 
        
           import { getOwner } from '@ember/application'; 
        
           import { dasherize } from '@ember/string'; 
        
           const storage = {}; 
        
           function tryStorage(name) {

There are two options to fix this issue:

adding dasherize as internal function (not braking - recommended)
adding @ember/string as peerDependency (braking)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment