Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - Translators needed! #506

Open
2 of 3 tasks
fujiapple852 opened this issue Apr 18, 2023 · 4 comments
Open
2 of 3 tasks

i18n - Translators needed! #506

fujiapple852 opened this issue Apr 18, 2023 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed i18n tracking

Comments

@fujiapple852
Copy link
Owner

fujiapple852 commented Apr 18, 2023

Tracking issue for adding i18n support to Trippy.

How to Help

Validate Machine Generated Translations

The table below contains links to PRs which contain machine generated translations for a variety of languages. Those marked as "help needed!" require a native speaker to review the associated PRs and suggest any corrections.

Changes can be made by starting a Github code review and suggesting changes, or alternative by adding comments to the PR.

Testing of the changes is not required, but if you wish to do so there are instructions below.

Add Additional Languages

If you wish to add support for an additional language, either create a new PR for that language or reply to this issue requesting a new PR containing machine generated translation for that language, which you can then review.

Locale Support

Language Code Status Reviewers Review Date PR
English en merged @fujiapple852 2024-09-28 #1321
French fr merged @zarkdav 2024-09-30 #1322
Turkish tr merged @orhun, @arda-guler 2024-10-04 #1330
Chinese zh merged @sxyazi 2024-10-18 #1333
Portuguese pt merged @ulissesf 2024-10-18 #1334
Swedish sv merged @0323pin 2024-11-02 #1354
Italian it merged @ricott1 2024-10-17 #1355
Russian ru merged @histrio 2024-11-04 #1345
Spanish es merged @josueBarretogit 2024-11-05 #1325
German de merged @peshay 2024-11-08 #1331
Hindi hi in progress @kiranyele18 #1343
Dutch nl awaiting review Help needed! #1332
Korean ko awaiting review Help needed! #1335
Japanese jp awaiting review Help needed! #1342
Arabic ar awaiting review @tsallabi #1344

Additional locales not on this list are also welcome.

Language and Region

Locales can be specified for a language or a language and a region. For example, a general locale can be created for zh (Chinese) and a more specific locales such as zh-CN (China) and zh-HK (Hong Kong) can be created.

If the users chosen full locale (langauge-region) does not exist, then Trippy will fallback to using the locale for the language only, if it exists. For example, if the user sets a locale of zh-TW (which, assume, does not have a locale defined in Trippy) it will fallback to using the zh locale if it is defined.

Locales should generally be added to Trippy for the language only, except where it makes sense to have different translations per region as well.

Fallback

If the users chosen locale does not exists in Trippy it will fallback to en (English). Fallback is per word/phrase in the locale, and so it is possible to have a locale defined with only a subset of words/phrases, with the remainder falling back to en.

Testing

If you wish to see how the translations look and feel for a given locale you can checkout the PRs linked above (where xx is the locale code):

git clone https://github.com/fujiapple852/trippy.git
git checkout feat-i18n-xx
cargo build

Then run Trippy with the --tui-locale xx option (where xx is the locale code):

sudo ./target/debug/trip --tui-locale xx example.com

Tasks

@fujiapple852 fujiapple852 added enhancement New feature or request tui labels Apr 19, 2023
@fujiapple852 fujiapple852 self-assigned this Apr 20, 2024
@fujiapple852 fujiapple852 added this to the 0.11.0 milestone Apr 20, 2024
@fujiapple852 fujiapple852 modified the milestones: 0.11.0, 0.12.0 Jul 23, 2024
@fujiapple852 fujiapple852 added tracking and removed enhancement New feature or request tui labels Sep 28, 2024
@fujiapple852 fujiapple852 changed the title Add support for i18n i18n Sep 28, 2024
@fujiapple852 fujiapple852 removed this from the 0.12.0 milestone Sep 30, 2024
@fujiapple852 fujiapple852 removed their assignment Sep 30, 2024
@fujiapple852 fujiapple852 added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 30, 2024
@fujiapple852 fujiapple852 pinned this issue Nov 3, 2024
@fujiapple852 fujiapple852 changed the title i18n i18n - Translators needed! Nov 3, 2024
@tsallabi
Copy link

tsallabi commented Nov 8, 2024

Salam
What you need to translate ?
Please let me know
I don't know where to start from
Thank you

@c-git
Copy link
Collaborator

c-git commented Nov 8, 2024

Hi @tsallabi thank you for your help. The PR for Arabic is #1344 , it has the machine generated translations and what we would want you to do is take a look at them and let us know which ones are should be changed. You'll see the machine generated suggestions under files. You can suggestion changes using GitHub's suggestions feature, replies on the PR or any way that's easier for you and I'll work with that. Let me know what you prefer and if you want more detailed instructions for any part. If you're doing it from a computer this link will take you directly to the list of translations https://github.com/fujiapple852/trippy/pull/1344/files it also works in the GitHub app but I don't have another phone to test without the app.

@tsallabi
Copy link

tsallabi commented Nov 8, 2024 via email

@c-git
Copy link
Collaborator

c-git commented Nov 8, 2024

Will email it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed i18n tracking
Projects
None yet
Development

No branches or pull requests

3 participants