Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor CI is failing due to some obscure problem with line endings #292

Open
dsyme opened this issue Jun 8, 2017 · 3 comments
Open

AppVeyor CI is failing due to some obscure problem with line endings #292

dsyme opened this issue Jun 8, 2017 · 3 comments

Comments

@dsyme
Copy link
Contributor

dsyme commented Jun 8, 2017

Yet again the dreaded SourceLink line ending obscure confusion strikes again

The AppVeyor CI is failing becuase line endings don't match for the generated Library.fs

@ctaggart
Copy link

ctaggart commented Jun 8, 2017

I'd recommend removing SourceLink v1 from Project Scaffold. When project scaffold support dotnet core projects, I'd recommend the project files add SourceLink v2 by adding SourceLink.Create.CommandLine to the proj files.

@sideeffffect
Copy link
Contributor

sideeffffect commented Jun 8, 2017

are you referring to SourceLink.Fake 1.1.0?
if that's the case, are you planning to create version 2.x?
thanks

@ctaggart
Copy link

ctaggart commented Jun 8, 2017

@sideeffffect I am referring to SourceLink.Fake. It isn't needed for version 2. It is a much simpler process and a different/new feature. You simply add one ProjectReference and you are done. With 15.3 of Visual Studio, it will work with Windows PDB files too and the debugger will match different line endings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants