Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed id and pkgd.min file #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed id and pkgd.min file #57

wants to merge 1 commit into from

Conversation

Geet06
Copy link
Contributor

@Geet06 Geet06 commented May 28, 2019

No description provided.

@@ -4,7 +4,7 @@ import {ObserverLocator} from "aurelia-binding";
import {Config} from './froala-editor-config';

// Import Froala Editor
import FroalaEditor from 'froala-editor/js/froala_editor.pkgd.min.js'
import FroalaEditor from 'froala-editor/js/froala_editor.min.js'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Geet06 import FroalaEditor from 'froala-editor'; we should use this instead of js file.

@navneetnagpal
Copy link
Contributor

@Geet06 Event are not binded the way they should be.
e.g.
this.instance.addEventListener('contentChanged', (e, editor) => this.value = editor.html.get());
this.instance.addEventListener('blur', (e, editor) => this.value = editor.html.get())

we should use this.instance.events.on('contentChanged',()=>{...}) like this.
Checkout this
https://github.com/froala/angular-froala-wysiwyg/blob/master/src/editor/editor.directive.ts
@ function initListeners() only initialized you can bind in custom way.
Reset should be instance.events.on().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants