-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dramatic change in GTs with smaller size DEL SV #530
Comments
Oh forgot to mention but we did compared the settings between 2.3.3 & 2.5.2 and notice that 2 option were disabled as default |
Hi Tuan, Thanks for the detailed writeup - I'll take a look to see if I can reproduce this, this certainly looks like an issue with the genotyper. Is it possible for you to share a snippet of the BAM-Files for the maybe the first two samples in your first post (i.e. just the reads surrounding the SV location)? Did you generate the incorrect single sample VCF and SNF files with v2.5 as well? Thanks, |
Hi @hermannromanek , Can you check these two bams, homoz_ind is the 1st individual, hetero is the 2nd. Would be great if you can patch this :) Many thanks, Tuan |
Forgot to mention but we did reproduce the sample VCF and SNF files with v2.5.2 Tuan |
Hi Tuan, Thank you so much - those were incredibly helpful, I identified the problem and will try to come up with a fix. It looks like the genotyping bug we fixed was masking another bug with coverage calculations, which causes this. I'll keep you updated, Thanks, |
(cherry picked from commit 3fb4494)
Hi Tuan, I just pushed a fix for this, is it possible for you to run the development version (i.e. a checkout of this repo)? We'll try to get this fix into a v2.5.3 as soon as possible. As you noticed correctly, this bug affected the genotyping of homozygous DELs, although I think it should have affected all DELs independently of length. Do you have any examples of DEL 1/1 calls of Sniffles 2.5.2, because I think there shouldn't have been any due to this bug, so there might be something else wrong there? Thanks, |
Hi @hermannromanek , Thanks for the quick fix, it fixes the issue
I looked at the old version and there were a few DEL - 18 vs a whooping 4541 INS, some below.
Cheers, Tuan |
Hi @hermannromanek , In addition to the checking up per individual, we also look at SV stats globally and retest using our 108 anims set. HWE & ExHet now coming back to the level of 233. We also meet with our consortium partners this morning, and propose a rerun with new SNF version (2.5.2), did you come up with any solution where we can use the old SNF (which @fritzsedlazeck discussed in issue #505) ? Also, once the release has been approve, could you please update the conda package :D Cheers, Tuan |
Hey @tuannguyen8390 we just put out the new version that should fix this GT issue. Conda update was also pushed. Part of the release was a --re-qc parameter for the merge. This resets the filters. Note that this improves calling on old SNF files but there might be some cases where its not equivalent of the new version of SNF files.. Hope that helps |
Hi @fritzsedlazeck @lfpaulin @hermannromanek
We've been comparing results from new v.2.5.2 with older genotypes (v2.2 snf & then v 2.3.3 for joint call/merge with pct-seq=0) on a set of 108 ONT cattle sequences (~10x – 25X).
As expected, with v2.5.2 we found fewer large DEL with 1/1 genotypes & for several known recessive lethals genotypes were corrected to 0/1 as reported on a different issue thread.
However, with v2.5.2 we also found that 1/1 genotypes for smaller DEL (<5 kb) were also substantially changed from 1/1 to 0/1. For example, with DEL < 5kb we record that 15% of the GTs changed from 2.3.3 -> 2.5.2, with DEL 5-10Kb it's 19%. The number was <1% for INS.
We also test bam visualisation for one SV, the 1st and 5 individual was
Now called as 0/1:60:14:12:Sniffles2.DEL.20E2SA in 2.5.2 (was 1/1 in 2.3.3)
Now called as 0/1:60:23:23:Sniffles2.DEL.1969SA in 2.5.2 (was 1/1 in 2.3.3)
At the moment we haven't looked at more than a few examples so far, but will do soon tomorrow
Hardy-Weinberg Equilibrium (HWE) analysis indicates that version 2.5.2 also produced a large increase in proportion of smaller DEL deviating from HWE, with an excess of heterozygous calls compared to 2.3.3.
Cheers,
Tuan
The text was updated successfully, but these errors were encountered: