Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signals to be saved #9

Open
frinio opened this issue Feb 3, 2018 · 3 comments
Open

Fix signals to be saved #9

frinio opened this issue Feb 3, 2018 · 3 comments

Comments

@frinio
Copy link
Owner

frinio commented Feb 3, 2018

Audio signals that are being saved (i.e inverse, equalized), have a variable dB difference with the audio signals reproduced outside the app with the same coefficients.
This is caused by the normalization on the magnitude inside the app for the purpose of better visualization.

Update
If no normalization takes place, then the audio signals to be saved will possibly be clipped.
Leave this issue open, until I give it some more thought.

@frinio
Copy link
Owner Author

frinio commented Feb 3, 2018

Pole fitting method does not normalize the inverse impulse response. It is passed as is to the main gui.

Check what is happening with the normalization throughout the app.

@frinio
Copy link
Owner Author

frinio commented Feb 3, 2018

Make sure all calculations are done with the original signals and normalizations are applied in the end or when visualizations are enabled.

@frinio
Copy link
Owner Author

frinio commented Feb 4, 2018

Functions to fix:
calc_correction_pushbutton_Callback and all functions that return the corrected_imp.

@frinio frinio changed the title Issue-#8 Fix signals to be saved Fix signals to be saved Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant