Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support #437

Open
patrickberkeley opened this issue Aug 3, 2021 · 2 comments · May be fixed by #621
Open

TypeScript support #437

patrickberkeley opened this issue Aug 3, 2021 · 2 comments · May be fixed by #621

Comments

@patrickberkeley
Copy link

Thanks for this library! Are there any plans for TS support either by converting to TS, or publishing type declarations?

@kiwi-josh
Copy link

Bump on this, I would also be interested to hear peoples thoughts on how they use this addon in combo with TS

@kiosion kiosion linked a pull request Dec 16, 2022 that will close this issue
@kiosion
Copy link
Contributor

kiosion commented Jan 17, 2023

Just to add onto this, I created an initial PR for converting the addon to Typescript. It's functional, but missing proper types for any of the breakpoint getters - they're added to the service at runtime from queries provided in the breakpoints.js file, so I'm not sure the best approach for typing them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants