Docker Published to GitHub #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
commented
Apr 2, 2024
| @@ -1,4 +1,4 @@ | |||
| SMF_CONFIG_NETWORK="rococo" | |||
| SMF_CONFIG_NETWORK="frequencyRococo" | |||
There was a problem hiding this comment.
Cleaning up the example to work out of the box
wilwade
commented
Apr 2, 2024
Comment on lines
-29
to
-34
| # Database | ||
| SMF_CONFIG_DB_HOST=localhost | ||
| SMF_CONFIG_DB_PORT=5432 | ||
| SMF_CONFIG_DB_USERNAME=postgres | ||
| SMF_CONFIG_DB_PASSWORD=postgres | ||
| SMF_CONFIG_DB_DATABASE_NAME=faucet |
There was a problem hiding this comment.
Unused due to switching back to sqlite
wilwade
commented
Apr 2, 2024
wilwade
commented
Apr 2, 2024
| .Get("FAUCET_IGNORE_LIST") | ||
| .split(",") | ||
| .map((item) => item.replace('"', "")); | ||
| const ignoreList = (config.Get("FAUCET_IGNORE_LIST") || "").split(",").map((item) => item.replace('"', "")); |
There was a problem hiding this comment.
Resolves issues with config not always returning an empty string default.
This reverts commit 9441eaa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to publish docker images to GitHub
Checklist
How To Test the Changes