Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs Final Review #87

Closed
18 tasks done
Tracked by #93
wilwade opened this issue Oct 28, 2024 · 1 comment
Closed
18 tasks done
Tracked by #93

Docs Final Review #87

wilwade opened this issue Oct 28, 2024 · 1 comment
Assignees
@wilwade
Labels
developer-portal
Milestone
Developer Portal

Comments

@wilwade
Copy link
Contributor

wilwade commented Oct 28, 2024 •
edited
Loading

  • Double check mobile
  • Double check print styles
  • Design Pair
  • bottom nav button highight
  • button-links needs a better hover
  • Header and Footer Cleanups #105 Prev/next chapter buttons are off-center due to the left menu nav (might just need to pad the right hand side)
  • Prev/next chapter buttons look strange when in mobile and end up stacking #104
  • Dark version of the header and footer
  • Readability is not consistent: The inner container seems to be sizing in and out based on content aka something needs a width 100% somewhere
  • Double check that the developer portal button should have the active state? Nope
  • Expand the minimum size of the center "row" so that the page always scrolls some when on a short browser.
  • Cohesive header with xyz #101
  • Final illustrations #102
  • Fixed in Switch to Grid and Footer #97 Hide header on print
  • Fixed in Switch to Grid and Footer #97 There's about a 20px gap at 800px-819px where the mobile nav looks funny though, it's at an iPad width when the Dev Docs link goes to two lines.
  • Think about using local storage to store the sidebar width across links (Not now)
  • Header logo should at least start centered over the nav bar
  • Remove the teal on blue
@wilwade wilwade mentioned this issue Oct 29, 2024
Closed
12 tasks
@wilwade wilwade added this to the Developer Portal milestone Oct 29, 2024
@wilwade wilwade mentioned this issue Oct 31, 2024
Merged
@wilwade wilwade self-assigned this Nov 7, 2024
@wilwade wilwade mentioned this issue Nov 13, 2024
Merged
wilwade added a commit that referenced this issue Nov 13, 2024
@wilwade
Header and Footer Cleanups (#105)
5a4685e 
Problem
=======

Various small layout issues addressed (one of a few PRs for this sort of
stuff)

Closes #101
Closes #104 
Closes #86
Part of #87

Solution
========
- Fix font issue with Bold
- Remove dead styles
- Fix content margins to handle the left nav buttons with centering
- Fix the previous/next buttons on mobile
- Add a margin to the footer to fix the footer border from hitting the
side nav (slight design break)
@wilwade wilwade mentioned this issue Nov 15, 2024
Merged
wilwade added a commit that referenced this issue Nov 15, 2024
@wilwade
Header Updates (#108)
0642c19 
Problem
=======

- Get the header updated to the correct colors and width patterns
- Update headers in light mode to be primary
- Move all text-navy to text-primary

Part of #87
@wilwade wilwade mentioned this issue Nov 15, 2024
Merged
wilwade added a commit that referenced this issue Nov 15, 2024
@wilwade
Pile of Minor Fixes (#110)
82c9ea9 
Problem
=======

Various small fixes for the final tweaks of the docs

Closes: #87
@wilwade
Copy link
Contributor Author

wilwade commented Nov 15, 2024

Closed by #110

@wilwade wilwade closed this as completed Nov 15, 2024
wilwade added a commit that referenced this issue Nov 19, 2024
@wilwade
Header and Footer Cleanups (#105)
d8f008c 
Problem
=======

Various small layout issues addressed (one of a few PRs for this sort of
stuff)

Closes #101
Closes #104 
Closes #86
Part of #87

Solution
========
- Fix font issue with Bold
- Remove dead styles
- Fix content margins to handle the left nav buttons with centering
- Fix the previous/next buttons on mobile
- Add a margin to the footer to fix the footer border from hitting the
side nav (slight design break)
wilwade added a commit that referenced this issue Nov 19, 2024
@wilwade
Header Updates (#108)
869ef70 
Problem
=======

- Get the header updated to the correct colors and width patterns
- Update headers in light mode to be primary
- Move all text-navy to text-primary

Part of #87
wilwade added a commit that referenced this issue Nov 19, 2024
@wilwade
Pile of Minor Fixes (#110)
df5b93b 
Problem
=======

Various small fixes for the final tweaks of the docs

Closes: #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilwade wilwade

Labels
developer-portal
Projects
None yet
Milestone
Developer Portal
Development

No branches or pull requests
1 participant
@wilwade