Repairs: Ignore invalid entity IDs in all cases (#176)

frenck · May 26, 2023 · f5c6d7d · f5c6d7d
1 parent 52e1d66
commit f5c6d7d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/custom_components/spook/repairs/automation_unknown_entity_references.py b/custom_components/spook/repairs/automation_unknown_entity_references.py
@@ -10,6 +10,7 @@
     ENTITY_MATCH_NONE,
     EVENT_COMPONENT_LOADED,
 )
+from homeassistant.core import valid_entity_id
 from homeassistant.helpers import entity_registry as er
 from homeassistant.helpers.dispatcher import async_dispatcher_connect
 from homeassistant.helpers.entity_component import DATA_INSTANCES, EntityComponent
@@ -106,6 +107,7 @@ async def async_inspect(self) -> None:
                         ),
                     )
                     and entity_id not in entity_ids
+                    and valid_entity_id(entity_id)
                 )
             }:
                 self.async_create_issue(

diff --git a/custom_components/spook/repairs/group_unknown_members.py b/custom_components/spook/repairs/group_unknown_members.py
@@ -7,6 +7,7 @@
     ENTITY_MATCH_NONE,
     EVENT_COMPONENT_LOADED,
 )
+from homeassistant.core import valid_entity_id
 from homeassistant.helpers import entity_registry as er
 from homeassistant.helpers.entity_platform import DATA_ENTITY_PLATFORM, EntityPlatform
 
@@ -83,6 +84,7 @@ async def async_inspect(self) -> None:
                             ("device_tracker.", "group.", "scene."),
                         )
                         and entity_id not in entity_ids
+                        and valid_entity_id(entity_id)
                     )
                 }:
                     self.async_create_issue(

diff --git a/custom_components/spook/repairs/lovelace_unknown_entity_references.py b/custom_components/spook/repairs/lovelace_unknown_entity_references.py
@@ -11,7 +11,7 @@
     ENTITY_MATCH_NONE,
     EVENT_COMPONENT_LOADED,
 )
-from homeassistant.core import callback
+from homeassistant.core import callback, valid_entity_id
 from homeassistant.helpers import entity_registry as er
 from homeassistant.helpers.dispatcher import async_dispatcher_connect
 
@@ -117,6 +117,7 @@ async def async_inspect(self) -> None:
                         ),
                     )
                     and entity_id not in entity_ids
+                    and valid_entity_id(entity_id)
                 )
             }:
                 title = "Overview"

diff --git a/custom_components/spook/repairs/script_unknown_entity_references.py b/custom_components/spook/repairs/script_unknown_entity_references.py
@@ -10,6 +10,7 @@
     ENTITY_MATCH_NONE,
     EVENT_COMPONENT_LOADED,
 )
+from homeassistant.core import valid_entity_id
 from homeassistant.helpers import entity_registry as er
 from homeassistant.helpers.dispatcher import async_dispatcher_connect
 from homeassistant.helpers.entity_component import DATA_INSTANCES, EntityComponent
@@ -107,6 +108,7 @@ async def async_inspect(self) -> None:
                         ),
                     )
                     and entity_id not in entity_ids
+                    and valid_entity_id(entity_id)
                 )
             }:
                 self.async_create_issue(