Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise backup format to not consist of serialized Java objects #381

Open
alexbakker opened this issue Dec 27, 2023 · 0 comments
Open

Revise backup format to not consist of serialized Java objects #381

alexbakker opened this issue Dec 27, 2023 · 0 comments

Comments

@alexbakker
Copy link

Today I took a quick look at adding support for importing FreeOTP 2 backup files to Aegis. To my surprise, the backup file starts with:

��srjava.util.HashMap��

I didn't spend any time trying to find a gadget chain to exploit this. Perhaps there is none. But I'd like to not have to worry about a maliciously crafted FreeOTP backup file potentially executing arbitrary code in the context of Aegis' app process.

I'd like to suggest revising the backup format to not consist of serialized Java objects, but to use something like JSON instead.

juleskers added a commit to juleskers/Aegis that referenced this issue Jul 2, 2024
Include the '(1.x)' qualifier directly in the import-source selection dropdown to avoid raising false expectations.

See also:
- beemdevelopment#1204, where the 1.x-hint was introduced
- beemdevelopment#1084: tracking issue for 2.x support
- freeotp/freeotp-android#381
  FreeOTP-issue to reconsider the brittle serialised java format used by 2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant