Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Remove OIDC return_uri hack #4

Open
mkosek opened this issue Nov 21, 2017 · 3 comments
Open

Remove OIDC return_uri hack #4

mkosek opened this issue Nov 21, 2017 · 3 comments

Comments

@mkosek
Copy link
Member

mkosek commented Nov 21, 2017

As FreeIPA wiki is running behind proxy, it's internal URI is different from the exposed one. I had to hack OIDC plugin to return a configured return URI, otherwise Ipsilon would reject the OIDC authentication: cc32652.

This hack should be fixed, otherwise the OIDC plugin needs to be hacked again after every update.

@simo5
Copy link

simo5 commented Nov 21, 2017

Can you upstrem a configuration setting to the plugin, so that everyone benefits from it and we do not have to hack it every time ? Running behind reverse proxies is pretty common these days.

@mkosek
Copy link
Member Author

mkosek commented Nov 22, 2017

Related change that works with vendor being built dynamically: 1479e11

@mkosek
Copy link
Member Author

mkosek commented Nov 22, 2017

@simo5, yes, that's my plan actually. This is why I created this ticket, to remind me/us to remove this hack!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants