Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow when calling vector.min, vector.max and vector.range #26

Open
matomesc opened this issue Oct 3, 2014 · 0 comments
Open

Comments

@matomesc
Copy link

matomesc commented Oct 3, 2014

Since you're doing Math.apply({}, values) when calculating .min(), .max() and .range(), then if the values is a large array (say 1000k items) then the stack will overflow. It might be better to rewrite the min/max/range so they take an array as parameter rather than delegating to Math.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant