From c96189286f4c5f103bb3583755c509a9813174ff Mon Sep 17 00:00:00 2001 From: Sherin KR Date: Fri, 22 Nov 2024 15:45:29 +0530 Subject: [PATCH 1/2] fix: redundant fetching of Interviewers in Interview --- hrms/hr/doctype/interview/interview.js | 1 + 1 file changed, 1 insertion(+) diff --git a/hrms/hr/doctype/interview/interview.js b/hrms/hr/doctype/interview/interview.js index 7586e7fe68..0698e48d95 100644 --- a/hrms/hr/doctype/interview/interview.js +++ b/hrms/hr/doctype/interview/interview.js @@ -221,6 +221,7 @@ frappe.ui.form.on("Interview", { interview_round: frm.doc.interview_round || "", }, callback: function (r) { + frm.clear_table("interview_details"); r.message.forEach((interviewer) => frm.add_child("interview_details", interviewer), ); From 5e4ed7522a7caa6e475df17b52f86d3936da9a42 Mon Sep 17 00:00:00 2001 From: Sherin KR Date: Mon, 25 Nov 2024 20:51:39 +0530 Subject: [PATCH 2/2] fix: whitespace linter issues Co-authored-by: Rucha Mahabal --- hrms/hr/doctype/interview/interview.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hrms/hr/doctype/interview/interview.js b/hrms/hr/doctype/interview/interview.js index 0698e48d95..2bccba56fa 100644 --- a/hrms/hr/doctype/interview/interview.js +++ b/hrms/hr/doctype/interview/interview.js @@ -221,7 +221,7 @@ frappe.ui.form.on("Interview", { interview_round: frm.doc.interview_round || "", }, callback: function (r) { - frm.clear_table("interview_details"); + frm.clear_table("interview_details"); r.message.forEach((interviewer) => frm.add_child("interview_details", interviewer), );