-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gantt chart view in the attendance #2061
base: develop
Are you sure you want to change the base?
fix: gantt chart view in the attendance #2061
Conversation
start: "start", | ||
end: "end", | ||
start: "attendance_date", | ||
end: "attendance_date", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break the calendar view?
Since the backend API passes start & end and as the attendance_date
and attendance_date
is not explicitly passed
hrms/hrms/hr/doctype/attendance/attendance.py
Lines 270 to 271 in 0487ba2
"start": d.attendance_date, | |
"end": d.attendance_date, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue has been present for a long time. I use my ERP hosted on Frappe Cloud and tried to update/add fields in the attendance doctype, but had no luck.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break the calendar view?
Hi @ruchamahabal,
The issue isn't breaking the calendar view; rather, it's showing a mismatch. Can you suggest what we should do about this?
When we add the attendance_date
, the Gantt chart works, but the calendar shows a mismatch. Conversely, when we use start
and end
, the calendar displays correctly, but the Gantt chart does not work.
@Nihantra-Patel Hello |
Any update ? Still facing the same issue on frappe cloud. |
version 15
fixes: https://discuss.frappe.io/t/server-error-in-gantt-chart-view-in-the-attendance-doctype/128167?u=ncp
Before:
After: