Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gantt chart view in the attendance #2061

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Nihantra-Patel
Copy link
Contributor

version 15

fixes: https://discuss.frappe.io/t/server-error-in-gantt-chart-view-in-the-attendance-doctype/128167?u=ncp

Before:

image

After:

  • There is no start and end field for the attendance doctype.

image

start: "start",
end: "end",
start: "attendance_date",
end: "attendance_date",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the calendar view?

Since the backend API passes start & end and as the attendance_date and attendance_date is not explicitly passed

"start": d.attendance_date,
"end": d.attendance_date,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue has been present for a long time. I use my ERP hosted on Frappe Cloud and tried to update/add fields in the attendance doctype, but had no luck.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the calendar view?

Hi @ruchamahabal,

The issue isn't breaking the calendar view; rather, it's showing a mismatch. Can you suggest what we should do about this?

When we add the attendance_date, the Gantt chart works, but the calendar shows a mismatch. Conversely, when we use start and end, the calendar displays correctly, but the Gantt chart does not work.

@rs115199789
Copy link

@Nihantra-Patel Hello
Any Update ?

@rs115199789
Copy link

Any update ? Still facing the same issue on frappe cloud.

@ArunaDevraj
Copy link

For the ERPNext: v15.42.0 (version-15)

Frappe Framework: v15.47.2 (version-15)

Frappe HR: v16.0.0-dev (develop)

It is rectified.

Screenshot from 2024-11-25 14-34-47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants