Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib3 Retry API change #22

Open
mgberg opened this issue May 17, 2023 · 0 comments · May be fixed by #23
Open

urllib3 Retry API change #22

mgberg opened this issue May 17, 2023 · 0 comments · May be fixed by #23

Comments

@mgberg
Copy link

mgberg commented May 17, 2023

As of urllib 2.0.0 (released 2023-04-26), the method_whitelist argument for Retry (which has been deprecated for a while) was removed in favor of allowed_methods.

However, the removed argument is still referenced here:

agraph-python/src/franz/miniclient/backends/requests.py

Lines 36 to 39 in 25b8963

retries = Retry(backoff_factor=0.1,
connect=10, # 10 retries for connection-level errors
status_forcelist=(), # Retry only on connection errors
method_whitelist=False) # Retry on all methods, even POST and PUT

Therefore, pinning the version of urllib3 is required. It would be great if this long-deprecated, now removed argument was replaced with the proper one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mgberg