Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when updating everything #58

Open
franc6 opened this issue Nov 30, 2020 · 0 comments
Open

Crash when updating everything #58

franc6 opened this issue Nov 30, 2020 · 0 comments
Assignees
@JimH44
Labels
bug Something isn't working fixed A fix is in git; fix needs to be reviewed before the issue can be closed

Comments

@franc6
Copy link
Owner

franc6 commented Nov 30, 2020

When updating all applications (with none downloaded already!), I saw a crash for an unhandled exception in UrlVariable.ReplaceFunction().

The problem was that String.Replace was called with a 0-length "oldvalue" parameter. I'm not sure how it was an empty string, but fixing the crash is straight-forward.
franc6 pushed a commit that referenced this issue Nov 30, 2020
Fixed #58
3491f55 
Updated code to not call String.Replace() if we have an empty string for
what to replace.
@franc6 franc6 added bug Something isn't working fixed A fix is in git; fix needs to be reviewed before the issue can be closed labels Nov 30, 2020
@franc6 franc6 assigned franc6 and JimH44 and unassigned franc6 Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimH44 JimH44

Labels
bug Something isn't working fixed A fix is in git; fix needs to be reviewed before the issue can be closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franc6 @JimH44