Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About Dialog needs updated #27

Open
franc6 opened this issue Feb 8, 2019 · 1 comment
Open

About Dialog needs updated #27

franc6 opened this issue Feb 8, 2019 · 1 comment
Assignees
@JimH44
Labels
fixed A fix is in git; fix needs to be reviewed before the issue can be closed

Comments

@franc6
Copy link
Owner

franc6 commented Feb 8, 2019

Some changes were made to the About dialog as part of issue #13. However, the changes are sub-optimal. Determination of correct changes should be made only after determining if modifications for Mono will be accepted into the main project.
@JimH44 JimH44 mentioned this issue Mar 25, 2019
Open
franc6 pushed a commit that referenced this issue Jul 31, 2019
Fixed #27
28aeb18 
Added code to pull in the official Ketarin version number automatically.
As long as Properties/AssemblyInfo.cs gets updates to AssemblyVersion
and AssemblyFileVersion from the main Ketarin github repo, this
information should be correct.
@franc6
Copy link
Owner Author

franc6 commented Jul 31, 2019

About dialog should now show the main project's version number, too.

@franc6 franc6 added the fixed A fix is in git; fix needs to be reviewed before the issue can be closed label Jul 31, 2019
franc6 pushed a commit that referenced this issue Aug 6, 2019
Fixed #27 and Fixed #33
33c5732 
The appveyor configs were doing more than they should have with the
changes for commit 28aeb18.  These changes ensure those changes and the
build scripts won't stomp on each other as noted by JimH44 on issue #33.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimH44 JimH44

Labels
fixed A fix is in git; fix needs to be reviewed before the issue can be closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franc6 @JimH44