Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved pxth to reactive-forms monorepo #316

Merged
merged 12 commits into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bright-elephants-begin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'pxth': minor
---

Moved pxth to reactive-forms monorepo
7 changes: 0 additions & 7 deletions .eslintignore

This file was deleted.

3 changes: 0 additions & 3 deletions .eslintrc.json

This file was deleted.

18 changes: 9 additions & 9 deletions .github/workflows/changeset.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,22 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node 18
uses: actions/setup-node@v3
- name: Use Node 20
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: Install pnpm 8.x.x
uses: pnpm/action-setup@v2.2.4
- name: Install pnpm 9.12.3
uses: pnpm/action-setup@v4
with:
version: 8.x.x
version: 9.12.3

- name: Install global dependencies
run: pnpm install
- name: Install dependencies (with cache)
uses: covbot/pnpm-install-with-cache@v1

- name: Run changeset status
run: pnpm changeset status --since=origin/main
18 changes: 9 additions & 9 deletions .github/workflows/danger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@ jobs:
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Use Node 18.x
uses: actions/setup-node@v3
- name: Use Node 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- name: Install pnpm 8.x.x
uses: pnpm/action-setup@v2.2.4
- name: Install pnpm 9.12.3
uses: pnpm/action-setup@v4
with:
version: 8.x.x
version: 9.12.3

- name: Install dependencies
run: pnpm install
- name: Install dependencies (with cache)
uses: covbot/pnpm-install-with-cache@v1

- name: Danger
run: pnpm danger ci
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/format-files.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,26 @@ on:
jobs:
format:
name: Format and commit files
runs-on: ubuntu-latest
runs-on: windows-latest
if: github.actor != 'frachtbot'
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
token: ${{ secrets.BOT_GITHUB_TOKEN }}

- name: Use Node 18
uses: actions/setup-node@v3
- name: Use Node 20
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: Install pnpm 8.x.x
uses: pnpm/action-setup@v2.2.4
- name: Install pnpm 9.12.3
uses: pnpm/action-setup@v4
with:
version: 8.x.x
version: 9.12.3

- name: Install global dependencies
run: pnpm install
- name: Install dependencies (with cache)
uses: covbot/pnpm-install-with-cache@v1

- name: Format files
run: pnpm run format
Expand Down
94 changes: 51 additions & 43 deletions .github/workflows/main-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,49 +20,57 @@ jobs:
with:
filter: '@reactive-forms/*'

coverage:
name: Coverage report
needs: [generate_matrix]
if: ${{ !fromJson(needs.generate_matrix.outputs.empty) }}
runs-on: ubuntu-latest
strategy:
matrix:
package: ${{ fromJson(needs.generate_matrix.outputs.packages) }}
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
# coverage:
# name: Coverage report
# needs: [generate_matrix]
# if: ${{ !fromJson(needs.generate_matrix.outputs.empty) }}
# runs-on: ubuntu-latest
# strategy:
# matrix:
# package: ${{ fromJson(needs.generate_matrix.outputs.packages) }}
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# with:
# fetch-depth: 0

- name: Use Node 18.x
uses: actions/setup-node@v3
with:
node-version: 18.x
# - name: Use Node 20.x
# uses: actions/setup-node@v4
# with:
# node-version: 20.x

- name: Install pnpm 8.x.x
uses: pnpm/action-setup@v2.2.4
with:
version: 8.x.x
# - name: Install pnpm 9.12.3
# uses: pnpm/action-setup@v4
# with:
# version: 9.12.3

- uses: artiomtr/jest-coverage-report-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
test-script: pnpm run --prefix ../.. turbo run test --filter ${{ matrix.package.name }}
package-manager: pnpm
working-directory: ${{ matrix.package.path }}
# - uses: artiomtr/jest-coverage-report-action@v2
# with:
# github-token: ${{ secrets.GITHUB_TOKEN }}
# test-script: pnpm run --prefix ../.. turbo run test --filter ${{ matrix.package.name }}
# package-manager: pnpm
# working-directory: ${{ matrix.package.path }}

size:
# TODO: configure Size limit for all packages
name: Size limit
runs-on: ubuntu-latest
runs-on: windows-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node 20
uses: actions/setup-node@v4
with:
node-version: 20

- name: Install pnpm 8.x.x
uses: pnpm/action-setup@v2.2.4
- name: Install pnpm 9.12.3
uses: pnpm/action-setup@v4
with:
version: 8.x.x
version: 9.12.3

- name: Install dependencies (with cache)
uses: covbot/pnpm-install-with-cache@v1

- name: Size limit
uses: andresz1/size-limit-action@dd31dce7dcc72a041fd3e49abf0502b13fc4ce05
Expand All @@ -71,27 +79,27 @@ jobs:
package_manager: pnpm

build:
name: Build, lint, and test changed packages on Node 18
runs-on: ubuntu-latest
name: Build, lint, and test changed packages on Node 20
runs-on: windows-latest

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node 18
uses: actions/setup-node@v3
- name: Use Node 20
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: Install pnpm 8.x.x
uses: pnpm/action-setup@v2.2.4
- name: Install pnpm 9.12.3
uses: pnpm/action-setup@v4
with:
version: 8.x.x
version: 9.12.3

- name: Install global dependencies
run: pnpm install
- name: Install dependencies (with cache)
uses: covbot/pnpm-install-with-cache@v1

- name: Linting, testing & building changed packages
run: pnpm turbo run lint test build --filter=...[origin/${{ github.base_ref }}]
20 changes: 10 additions & 10 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,23 @@ jobs:
contents: write
timeout-minutes: 5
name: Release
runs-on: ubuntu-latest
runs-on: windows-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Setup Node.js 18.x
uses: actions/setup-node@v3
- name: Setup Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- name: Install pnpm 8.x.x
uses: pnpm/action-setup@v2.2.4
- name: Install pnpm 9.12.3
uses: pnpm/action-setup@v4
with:
version: 8.x.x
version: 9.12.3

- name: Install Dependencies
run: pnpm install
- name: Install dependencies (with cache)
uses: covbot/pnpm-install-with-cache@v1

- name: Creating .npmrc
run: |
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ dist
prepared-package
build
.rpt2_cache
.tsup

# misc
.DS_Store
Expand Down
24 changes: 24 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import path from "node:path";
import { fileURLToPath } from "node:url";
import js from "@eslint/js";
import { FlatCompat } from "@eslint/eslintrc";

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const compat = new FlatCompat({
baseDirectory: __dirname,
recommendedConfig: js.configs.recommended,
allConfig: js.configs.all
});

export default [{
ignores: [
"**/build/",
"**/dist/",
"**/node_modules/",
"**/.snapshots/",
"**/*.min.js",
"**/*.config.js",
"**/dangerfile.js",
],
}, ...compat.extends("@reactive-tools/eslint-config")];
25 changes: 14 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"repository": "fracht/reactive-forms.git",
"author": "Artiom Tretjakovas",
"license": "MIT",
"packageManager": "[email protected]",
"scripts": {
"build": "turbo run build --filter=@reactive-forms/*",
"bump": "changeset version && pnpm i --lockfile-only",
Expand All @@ -20,20 +21,22 @@
"turbo": "turbo"
},
"devDependencies": {
"@changesets/cli": "2.26.0",
"@octokit/core": "4.1.0",
"@changesets/cli": "2.27.9",
"@eslint/eslintrc": "^3.1.0",
"@eslint/js": "^9.13.0",
"@octokit/core": "6.1.2",
"@reactive-tools/eslint-config": "workspace:*",
"@size-limit/preset-small-lib": "8.1.0",
"@size-limit/preset-small-lib": "11.1.6",
"aqu": "0.4.3",
"clean-publish": "4.2.0",
"danger": "10.6.4",
"prettier": "2.5.1",
"size-limit": "8.1.0",
"syncpack": "8.2.5",
"turbo": "2.0.3",
"typescript": "4.8.4"
"clean-publish": "5.1.0",
"danger": "12.3.3",
"eslint": "^9.13.0",
"prettier": "3.3.3",
"size-limit": "11.1.6",
"syncpack": "13.0.0",
"turbo": "2.2.3",
"typescript": "5.6.3"
},
"packageManager": "[email protected]",
"size-limit": [
{
"path": "packages/core/dist/core.cjs.production.min.js",
Expand Down
3 changes: 0 additions & 3 deletions packages/autosave/.eslintignore

This file was deleted.

3 changes: 0 additions & 3 deletions packages/autosave/.eslintrc.json

This file was deleted.

8 changes: 8 additions & 0 deletions packages/autosave/eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import baseConfig from '@reactive-tools/eslint-config';

export default [
{
ignores: ['**/dist', '**/node_modules', '**/*.config.js'],
},
...baseConfig,
];
1 change: 1 addition & 0 deletions packages/autosave/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"@reactive-tools/eslint-config": "workspace:*",
"@types/react": "18.0.23",
"aqu": "0.4.3",
"eslint": "^9.13.0",
"jest": "29.2.2",
"react": "18.2.0",
"rimraf": "3.0.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/autosave/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
"noImplicitThis": true,
"noImplicitAny": true,
"strictNullChecks": true,
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"allowSyntheticDefaultImports": true,
"noFallthroughCasesInSwitch": true,
"rootDir": "./src",
"strict": true,
"importHelpers": true
"importHelpers": true,
"skipLibCheck": true
},
"include": ["src", "types"]
}
Loading
Loading