Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll dialogs no longer have contextual window titles #4787

Open
MaxPat931 opened this issue Nov 26, 2024 · 2 comments · May be fixed by #4884
Open

Roll dialogs no longer have contextual window titles #4787

MaxPat931 opened this issue Nov 26, 2024 · 2 comments · May be fixed by #4884
Assignees
@roth-michael
Labels
system: dice Dice rolling functionality ui User interface related features or bugs
Milestone
D&D5E 4.2.0

Comments

@MaxPat931
Copy link
Contributor

Titles are now all "Configure Roll" instead of the contextual information they used to provide

3.2.1 4.1.2 Proposed
image image image
@etiquettestartshere
Copy link
Contributor

it seems to me the data can still even be provided, for instance in rollAbilityCheck's second arg, { options: { title: { "Title Here" }}}, but its just not used anywhere

@roth-michael roth-michael linked a pull request Dec 15, 2024 that will close this issue
Open
@arbron arbron added this to the D&D5E 4.2.0 milestone Dec 27, 2024
@arbron arbron added ui User interface related features or bugs system: dice Dice rolling functionality labels Dec 27, 2024
@roth-michael
Copy link
Contributor

Commenting for assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roth-michael roth-michael

Labels
system: dice Dice rolling functionality ui User interface related features or bugs
Projects
None yet
Milestone
D&D5E 4.2.0
Development

Successfully merging a pull request may close this issue.

[#4787] More informative roll dialog titles roth-michael/dnd5e
4 participants
@arbron @roth-michael @MaxPat931 @etiquettestartshere