Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All images in example templates are broken #1131

Open
viking1304 opened this issue Nov 22, 2022 · 0 comments
Open

All images in example templates are broken #1131

viking1304 opened this issue Nov 22, 2022 · 0 comments

Comments

@viking1304
Copy link

viking1304 commented Nov 22, 2022

Example templates use old HTTP links to plachold.it, which are now completely broken, for example http://placehold.it/200x50/663399

I replaced all of those links with new https://via.placeholder.com links and changed the display text (with text query parameter) to match the old images, since "Powered by HTML.COM" is very inconsistent. This text is not always visible and sometimes goes over the text with resolution.

Should I open a pull request with this change to this project or https://github.com/foundation/foundation-emails-template?

EDIT: Images are broken only if HTTP traffic is not allowed on your network (as in my corporate network). In cases where HTTP traffic is allowed, you will get the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant