Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline injects additional closing tags #1090

Open
sudofscka opened this issue Dec 20, 2021 · 0 comments
Open

Inline injects additional closing tags #1090

sudofscka opened this issue Dec 20, 2021 · 0 comments

Comments

@sudofscka
Copy link

How can we reproduce this bug?
Correct the inliner, inline should NOT add closing tags, its purpose is to inline, not edit the code. Closing tables, td, th, etc is not part of the inline process. The closing tags exist in the email, the Zurb inline just thinks they dont.

Write out the HTML (or Inky code) that causes the issue.
Building complex smart templates for a proprietary platform with multiple if else statements like:

{{#if (ifEq settings.dealerPrimaryMake '1234' true false)}}

{{else if (ifEq settings.dealerPrimaryMake '5678' true false)}}

What did you expect to happen?

{{#if (ifEq settings.dealerPrimaryMake '1234' true false)}} {{else if (ifEq settings.dealerPrimaryMake 'BMW' true false)}}

{{else if (ifEq settings.dealerPrimaryMake '5678' true false)}}

What happened instead?

{{#if (ifEq settings.dealerPrimaryMake '1234' true false)}} {{else if (ifEq settings.dealerPrimaryMake 'BMW' true false)}}
=


{{else if (ifEq settings.dealerPrimaryMake '5678' true false)}}

Notice the closing that the inliner injected

What email clients does this happen in?
N/A happening at inlined sourced code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant