feat: exit on unknown args #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChanderG <[email protected]>
ChanderG
requested review from
anhuong,
Ssukriti,
aluu317,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
| ) = parser.parse_args_into_dataclasses(return_remaining_strings=True) | ||
|
|
||
| peft_method = additional.peft_method | ||
| exp_metadata = additional.exp_metadata | ||
| if leftover: | ||
| logging.error("Extra un-recognized arguments found: %s", leftover) | ||
| sys.exit(USER_ERROR_EXIT_CODE) |
There was a problem hiding this comment.
Wouldn't be better to log and continue?
There was a problem hiding this comment.
Yes - that is also ok. I would prefer immediate exit - since there are usually a wall of log output and this can get missed out - but we can go with whatever is the consensus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Logs and errors out in case of unknown input args.
Related issue number
Closes #420
How to verify the PR
Simply run with some extra/flags with typos etc.
Was the PR tested
Manually.