Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat title bug #7

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Repeat title bug #7

merged 4 commits into from
Dec 7, 2023

Conversation

fosfrancesco
Copy link
Owner

Solved a BUG where "repeat" was included in Schumann Toccata Title. This posed problems when creating data splits without having the same piece in multiple splits.

The path of Schumann Toccata where also updated to follow the convention of other pieces
"Toccata" -> "Toccata_no_repeat"
"Toccata_repeat" -> "Toccata"

Removed repeat from the title of the Toccata_repeat of Schuman. It was creating problems with the unique pieces split
Created no_repeat for the Schumann Toccata to be consistent with the rest of the pieces
@fosfrancesco fosfrancesco linked an issue Jul 31, 2023 that may be closed by this pull request
@fosfrancesco fosfrancesco changed the base branch from master to develop December 7, 2023 13:42
@fosfrancesco fosfrancesco merged commit 0c73b4e into develop Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schumann Toccata, some titles include "_repeat" in metadata.csv
1 participant