Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inline styling for select component height #115

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

n/a

Description

It looks like Bootstrap 5 eliminated static height declaration for the form-control class, which caused select comps to appear ultra thin. This PR inlines that style to the template.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 060994d into main Dec 5, 2024
1 check passed
This was referenced Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant