FIO-9008 Added some of the missing accessibility tags to bootstrap5 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanbond
requested changes
Sep 25, 2024
| @@ -119,7 +119,7 @@ | |||
| <span> | |||
| <img ref="fileImage" src="" alt="{{file.originalName || file.name}}" style="width:{{ctx.component.imageSize}}px"> | |||
| {% if (!ctx.disabled) { %} | |||
| <i tabindex="0" class="{{ctx.iconClass('remove')}}" ref="removeLink"></i> | |||
| <i tabindex="0" class="{{ctx.iconClass('remove')}}" ref="removeLink" aria-label="Remove button. Press to remove {{file.originalName || file.name}} file"></i> | |||
There was a problem hiding this comment.
Kind of a minor nit but do we need to use ctx.t() here to potentially internationalize this accessibility message?
There was a problem hiding this comment.
@brendanbond as far as I know, ctx.t() only works with static strings. Will it work with a string that has variables like it has in that case?
There was a problem hiding this comment.
Yup, it takes interpolation context as a second arg, e.g. see here
brendanbond
reviewed
Oct 3, 2024
brendanbond
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://formio.atlassian.net/browse/FIO-9008