Bump go to 1.22 & all deps #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After bumping packages, envconfig behaviour has changed. If a struct contains a pointer, and no value is being loaded, it will now generate the zero value for the pointed type rather than nil.
This prevented the proxy from being started if no SERVER_ADDRESS was specified, as ConfigureProxy checks for no server address being specified by comparing it to url.URL{}, which because of the pointer is no longer equal.
The fix is a simple config change for envconfig so that it will use nil rather than the zero value for the pointer when no value is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps to version to v1.22 & all dependencies in preparation for creating a new release.
The envconfig upgrade included a breaking change which would cause no proxy to start if the
SERVER_ADDRESSenv var was not specified. A fix is included in its own commit, along with a unit test to prevent regression.