Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fd_viewControllerBasedNavigationBarAppearanceEnabled should be defaulted to NO and should be honored in the viewWillDisappear method #147

Open
joshuafeldman opened this issue Aug 4, 2017 · 1 comment
Open

fd_viewControllerBasedNavigationBarAppearanceEnabled should be defaulted to NO and should be honored in the viewWillDisappear method #147

joshuafeldman opened this issue Aug 4, 2017 · 1 comment

Comments

@joshuafeldman
Copy link

When using this library it will create various issues since it is swizzling all instances of UINavigationController. The default for controlling the navigation bar appearance, fd_viewControllerBasedNavigationBarAppearanceEnabled, should be NO so that it doesn't conflict with other implementations. The user should specify if they want to turn this feature on.
@joshuafeldman
Copy link
Author

Pull request with fix #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuafeldman