Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

OMG transferFrom interface is not have return bool value #36

Open
baoliang opened this issue Aug 2, 2018 · 0 comments
Open

OMG transferFrom interface is not have return bool value #36

baoliang opened this issue Aug 2, 2018 · 0 comments

Comments

@baoliang
Copy link

baoliang commented Aug 2, 2018

Hi,
When i deposit the OMG TOKEN
https://etherscan.io/address/0xd26114cd6EE289AccF82350c8d8487fedB8A0C07
, i find run error, i find out The OMG source transferFrom function not return any ,

contract ERC20 is ERC20Basic {
  function allowance(address owner, address spender) constant returns (uint);
  function transferFrom(address from, address to, uint value);
  function approve(address spender, uint value);
  event Approval(address indexed owner, address indexed spender, uint value);
}

but the ERC20 interface is require return bool type value. I find out this project deposit function's ERC20 interface is return bool value.
It run for deposit OMG will error. seems

    require(IToken(token).transferFrom(msg.sender, this, amount));

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant