This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Incorrect orders in socket getMarket response #108

Open

bugduino opened this issue Sep 2, 2018 · 2 comments

bugduino commented Sep 2, 2018 •

edited

Loading

Hi,
I'm trying to mirror the live order book using the websocket api.
Currently I get the initial data of all tickers by emitting a getMarket for each token, the problem is that the response I got is full of orders with incorrect prices (I suppose are old filled orders) like this one

which is not shown in the UI

or this one

which also is not in the UI

Why is this happening? How should I filter out all these orders?

Author

bugduino commented Sep 2, 2018

Using the etherdelta socket api I do not get these orders

Author

bugduino commented Sep 3, 2018

Should I use ethAvailableVolumeBase > 0.001 to filters valid orders? besides state !== 'CANCELED' && !state.deleted && (order is not expired)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.