Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6th review meeting #56

Closed
jongfeel opened this issue Jan 4, 2021 · 3 comments
Closed

6th review meeting #56

jongfeel opened this issue Jan 4, 2021 · 3 comments
Assignees
Labels
Gift Mentor's gift at after every 5th times reviews. Review Code Review

Comments

@jongfeel
Copy link
Collaborator

jongfeel commented Jan 4, 2021

Code review

Retrospect (회고)

  • 각자 개인이 따로 진행하는 것 같은데, 특별히 peer review에 대한 논의를 진행한 적이 있는지?
  • Review할게 pull request 한개 뿐이라 이런 경우에는 그냥 넘어가는게 좋을 듯 한데, 10~20분이라도 온라인 미팅을 진행하는게 좋을지?
@jongfeel
Copy link
Collaborator Author

jongfeel commented Jan 4, 2021

그리고 제가 오후 5시 ~ 6시 사이에 도착할 것 같습니다.

@jongfeel
Copy link
Collaborator Author

jongfeel commented Jan 5, 2021

peer review라고 할만한 내용과 문제들이 아니어서 각자 진행한 걸로 확인
짧게 끝나더라도 되도록이면 온라인으로 미팅 진행했으면 함.

@jongfeel jongfeel closed this as completed Jan 5, 2021
@fora22 fora22 added the Review Code Review label Jan 5, 2021
@fora22 fora22 added this to the Project Manage milestone Jan 5, 2021
@jongfeel jongfeel added the Gift Mentor's gift at after every 5th times reviews. label Jan 13, 2021
@jongfeel
Copy link
Collaborator Author

늦었지만 선물 드린거 사진 첨부해서 올려 드립니다.

경기대학교 제2공학관 404호에서 팽대원님 드림
IMG_0148

@jongfeel jongfeel pinned this issue Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gift Mentor's gift at after every 5th times reviews. Review Code Review
Projects
None yet
Development

No branches or pull requests

3 participants