Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd12 directory is missing #16

Open
ckoryom opened this issue Jun 1, 2022 · 3 comments
Open

cd12 directory is missing #16

ckoryom opened this issue Jun 1, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@ckoryom
Copy link

ckoryom commented Jun 1, 2022

On the fonts.md it's mentioned that we need to place our fonts into ./cd12, unfortunately it seems like the directory has been removed.

Is this on purpose?

@bjrkk
Copy link

bjrkk commented Jun 2, 2022

CD12 was merged into root (as it was a copy of the source code, mostly) as part of pull request #4. Placing the fonts is not necessary in order to build 3DMM itself.

@foone
Copy link
Owner

foone commented Jun 6, 2022

Yeah. cd12 was removed for cleanup. I'll make a fix to fonts.md to make this clearer.
We don't really need to place fonts anywhere as part of the new install process, so maybe just removing fonts.md would make more sense?

@ckoryom
Copy link
Author

ckoryom commented Jun 8, 2022

I actually got confused with the README, thought we needed to find the fonts and add them manually. Maybe just adding that extra part "Placing the fonts is not necessary anymore" but keeping fonts.md for historical purposes?

@frank-weindel frank-weindel added this to the Source Clean Up milestone Dec 7, 2022
@frank-weindel frank-weindel added the documentation Improvements or additions to documentation label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants