Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of supplier order unit in data sent to suppliers #75

Open
lentschi opened this issue Jun 29, 2024 · 0 comments
Open

Display of supplier order unit in data sent to suppliers #75

lentschi opened this issue Jun 29, 2024 · 0 comments
Labels
bug Something isn't working specification required
Milestone

Comments

@lentschi
Copy link
Contributor

lentschi commented Jun 29, 2024

Current behavior

  • Supplier order units are always rendered in reference to the group order unit - even for exported data sent to the supplier (e.g. "order fax").

Expected behavior

  • Supplier order units should not be rendered in reference to the group order unit, if the rendered data is intended for external use (Group order unit is a field that's to be used inside of foodcoops only.)
    TODO: Unclear how to go about this. Options mentioned so far (see discussion in Display of supplier order units like "Crate [of bottles]" #66):
    1. Always list all the ratios down to the first SI conversible unit. (Con: Leads to very long, overly verbose unit descriptions such as Pallet (100 box x 4 parcel x 10 package x 50 g))
    2. Introduce a new user-configurable article version db field supplier reference unit that is used to determine in reference to which SI unit external exports should be done. (Con: Effort implementing it and continuous effort maintaining the fields content for foodcoop users)
    3. Break down the supplier order unit to the first SI conversible unit. For deeply nested ratios this could lead to large numbers - e.g. Pallet (200000 g). To come by this issue one could use the user defined list of default units to find the unit with the smallest possible integer conversion and then render it as Pallet (200 kg) instead. (Con: Effort implementing; kind of unexpected that the list of default units should have an impact on how the data is exported.)
    4. Do not change anything (Maybe this issue is not worth the effort and other measures can be used for disambiguation - e.g. changing the article name. Currently it's not possible to add the exact same article name twice anyway - unless maybe... see Find a solution for broken name validation on article synchronization #57 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working specification required
Projects
None yet
Development

No branches or pull requests

1 participant