Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare spotipy as a dependency #466

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Declare spotipy as a dependency #466

merged 3 commits into from
Oct 31, 2024

Conversation

tsvi
Copy link
Contributor

@tsvi tsvi commented Oct 31, 2024

HA core has removed the dependency on spotipy in 2024.11 To keep the integration working this adds it back as a dependency. We might want to consider in the future using aiospotify. See here: home-assistant/core#127728

HA core has removed the dependency on spotipy in 2024.11
To keep the integration working this adds it back as a dependency.
We might want to consider in the future using aiospotify.
See here: home-assistant/core#127728
@tsvi
Copy link
Contributor Author

tsvi commented Oct 31, 2024

Note, that when running spot cast on 2024.11b0 we fail because of this.

custom_components/spotcast/manifest.json Outdated Show resolved Hide resolved
@fcusson
Copy link
Collaborator

fcusson commented Oct 31, 2024

@tsvi

Requested change, your current change request does not confrm to the manifest schema, please validate with documentation for python libary requirements

Can integrate as soon as this is fixed

@tsvi
Copy link
Contributor Author

tsvi commented Oct 31, 2024

I think this should fix it

@fcusson
Copy link
Collaborator

fcusson commented Oct 31, 2024

@tsvi, Thank you. Have you been able to test it is working from your side. I'm at the office, so won't be able to test until late tonight.

Also I looked into spotifyaio and it looks very new for the moment. The main benefit being that its an async library, while spotipy is a synchronous one.

Could be interesting, I'll look into replacing spotipy with it in my current build of v4 but if its a lot of hassle I don't want to delay the release of the next major build.

custom_components/spotcast/manifest.json Outdated Show resolved Hide resolved
@fcusson fcusson mentioned this pull request Oct 31, 2024
@fcusson
Copy link
Collaborator

fcusson commented Oct 31, 2024

@tsvi hassfest validation passed. I'll wait on a confirmation that everything is working as intended from your side. Otherwise, I'll be able to test when I'm back home

@tsvi
Copy link
Contributor Author

tsvi commented Oct 31, 2024

Fixed alphabetization
I also tested it locally and now home assistant loads correctly

@fcusson
Copy link
Collaborator

fcusson commented Oct 31, 2024

thanks for the confirmation, I'll draft a release

@fcusson fcusson merged commit 2a3f5da into fondberg:master Oct 31, 2024
1 check passed
@tsvi tsvi deleted the patch-2 branch October 31, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants