Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save state doesn't work correctly for games that make use of CHR RAM #35

Open
blahness opened this issue Jan 17, 2018 · 2 comments
Open

Comments

@blahness
Copy link

Since you're not saving the carts chr data when it's written to games such as Metroid have a black screen on state load. This same issue would apply to games making use of PRG RAM.

@fogleman
Copy link
Owner

@blahness Thanks - not sure how I missed this! Fixed now in master. Unfortunately it breaks existing savefiles, which may need to be rm'd from the ~/.nes/save folder.

@blahness
Copy link
Author

The INES header format states that if the CHR ROM size is 0 then it's CHR RAM. I think the best play is to mark the CHR data as RAM in that case & only save it in the state file if it's marked as RAM. Since your emulator in its current state doesn't allow PRG data to be written to there's no point in saving it right now. It's just something to keep in mind when it's supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants