Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve india and moldova for ISO3166-2 #360

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Improve india and moldova for ISO3166-2 #360

merged 2 commits into from
Dec 2, 2023

Conversation

XSpielinbox
Copy link
Contributor

@XSpielinbox XSpielinbox commented Oct 10, 2023 •
edited
Loading

🐞 fixes part of #267

However, it is missing translations at the moment, as I did not know how to translate them.

@XSpielinbox XSpielinbox mentioned this pull request Oct 10, 2023
Closed
@derTobsch
Copy link
Contributor

Good Morning,
please do not delete the German cities. I need to think about this again. We need this information at the urlaubsverwaltung. I will comment in the other ticket, how we could/should handle this. My first thoughts are: if it is a deterministic public holiday, based on fixed calculations, like the others we have atm, then we could keep them.

@XSpielinbox
Copy link
Contributor Author

Good Morning, please do not delete the German cities. I need to think about this again. We need this information at the urlaubsverwaltung. I will comment in the other ticket, how we could/should handle this. My first thoughts are: if it is a deterministic public holiday, based on fixed calculations, like the others we have atm, then we could keep them.

Ah, ok. Sorry.
Other ideas I just had: perhaps extract all these holidays, that are only applicable to a region smaller than a ISO 3166-2 subdivision to a separate library/module/package like jollyday-extra, jollyday-addons, jollyday-local, jollyday-ugly or jollyday-experimental, which then is way less complete and perhaps less stable/correct/tested, but whenever something of this small/partial scale comes up, one can add/correct it there and it would act like an extension to jollyday?
Or perhaps one could make every holiday applicable for the complete subdivision, but mark it as partial/regional only (maybe with an additional free text field of where it is applicable instead of an complete SubConfigurations)?

@XSpielinbox XSpielinbox force-pushed the fix_iso3166_part1 branch 2 times, most recently from 8f01d4f to 9f43429 Compare November 4, 2023 15:30
@derTobsch derTobsch added this to the 0.22.0 milestone Nov 7, 2023
@XSpielinbox
Fix Moldova
caed6cb 
Signed-off-by: XSpielinbox <[email protected]>
@XSpielinbox
Fix India
1e1162d 
Signed-off-by: XSpielinbox <[email protected]>
@derTobsch derTobsch changed the title Fix ISO3166 part1 Improve india and moldova for ISO3166-2 Nov 28, 2023
@derTobsch
Copy link
Contributor

Could you please remove the last commit with Bavaria? I would like to leave it like that and support die ISO 3166-2 and also cities with their "own" standard. I will provide some information in the main issue

@XSpielinbox
Copy link
Contributor Author

Could you please remove the last commit with Bavaria? I would like to leave it like that and support die ISO 3166-2 and also cities with their "own" standard. I will provide some information in the main issue

Ok, I will move it to a separate branch as soon as possible to not lose the commit.

@derTobsch derTobsch merged commit 6d1e3b0 into focus-shift:main Dec 2, 2023
9 checks passed
@XSpielinbox XSpielinbox deleted the fix_iso3166_part1 branch December 2, 2023 18:11
@XSpielinbox XSpielinbox mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@XSpielinbox @derTobsch