Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Id-ul- Fitr is one day later in India and applicable across the whole of India #280

Closed
XSpielinbox opened this issue Aug 24, 2023 · 1 comment · Fixed by #397
Closed

Comments

@XSpielinbox
Copy link
Contributor

XSpielinbox commented Aug 24, 2023

Affected country

India

Affected public holiday

Id-ul- Fitr

Source of the information

https://www.india.gov.in/calendar

More information

additional sources: https://en.wikipedia.org/wiki/Public_holidays_in_India#Islamic_holidays
for example states for this year: https://www.andaman.gov.in/admin-pannel/othersdoc/1-23-Public%20Holiday%20and%20Restricted%20Holiday%202023.pdf
https://www.goa.gov.in/wp-content/uploads/2022/10/Holidays-list-for-2023.pdf

So:

  1. It should be moved to apply to the whole of India, as it is currently missing in certain states.
  2. It should be moved one day later for all years (at least 2021, 2022 and 2024 too)
  3. It should be renamed from Eid ul-Fitr to Id-ul- Fitr, as this is the spelling of the Indian Goverment.
@XSpielinbox XSpielinbox added status: new Initial state for every issue / pull request topic: public holiday type: bug Something isn't working labels Aug 24, 2023
@XSpielinbox
Copy link
Contributor Author

I can also provide a PR for this, once #360 is merged.

@XSpielinbox XSpielinbox mentioned this issue Dec 10, 2023
XSpielinbox added a commit to XSpielinbox/jollyday that referenced this issue Feb 1, 2024
Signed-off-by: XSpielinbox <[email protected]>
@derTobsch derTobsch added this to the 0.25.0 milestone Feb 2, 2024
@derTobsch derTobsch added country: india and removed status: new Initial state for every issue / pull request labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants