From b2383af3ac0233e2962860eb8f0c67c97d0dd880 Mon Sep 17 00:00:00 2001 From: TungHoang Date: Thu, 11 May 2023 09:29:20 +0200 Subject: [PATCH] Remove global lock in RateLimitStore Signed-off-by: TungHoang --- plugins/rate_limit.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/plugins/rate_limit.go b/plugins/rate_limit.go index 4c81657de..3496fccc2 100644 --- a/plugins/rate_limit.go +++ b/plugins/rate_limit.go @@ -29,7 +29,6 @@ type LimiterStore struct { accessPerUser *sync.Map requestPerSec int burstSize int - mutex *sync.Mutex cleanupInterval time.Duration } @@ -55,8 +54,6 @@ func (l *LimiterStore) Allow(userID string) error { // clean removes the access records for users who have not accessed the system for a while func (l *LimiterStore) clean() { - l.mutex.Lock() - defer l.mutex.Unlock() l.accessPerUser.Range(func(key, value interface{}) bool { value.(*accessRecords).mutex.Lock() defer value.(*accessRecords).mutex.Unlock() @@ -70,7 +67,6 @@ func (l *LimiterStore) clean() { func newRateLimitStore(requestPerSec int, burstSize int, cleanupInterval time.Duration) *LimiterStore { l := &LimiterStore{ accessPerUser: &sync.Map{}, - mutex: &sync.Mutex{}, requestPerSec: requestPerSec, burstSize: burstSize, cleanupInterval: cleanupInterval,