Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add driverPod/executorPod in Spark #6085

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

machichima
Copy link
Contributor

Tracking issue

#4105

Why are the changes needed?

Enable setting K8sPod separately for Spark Driver and Executor pods.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Add driverPod/executorPod field in SparkJob class and use them as Spark
driver and executor

Signed-off-by: machichima <[email protected]>
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 10.33%. Comparing base (ba331fd) to head (1faaa00).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/plugins/spark.pb.go 0.00% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ba331fd) and HEAD (1faaa00). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (ba331fd) HEAD (1faaa00)
unittests-flytectl 1 0
unittests-flytestdlib 1 0
unittests-flyteplugins 1 0
unittests-flytepropeller 1 0
unittests-flyteadmin 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6085       +/-   ##
===========================================
- Coverage   37.10%   10.33%   -26.78%     
===========================================
  Files        1318      216     -1102     
  Lines      132331    45487    -86844     
===========================================
- Hits        49097     4699    -44398     
+ Misses      78961    40410    -38551     
+ Partials     4273      378     -3895     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin ?
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl ?
unittests-flyteidl 7.23% <0.00%> (-0.01%) ⬇️
unittests-flyteplugins ?
unittests-flytepropeller ?
unittests-flytestdlib ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix protobuf number mismatch

pass K8sPod instead of annotation and label separately

Signed-off-by: machichima <[email protected]>
successfully apply pods specify in SparkJob

Signed-off-by: machichima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant