Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ArrayNode subNode timeouts #6054

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

tests passing - still need to add validation

f34fb8f
Select commit
Loading
Failed to load commit list.
Draft

Support ArrayNode subNode timeouts #6054

tests passing - still need to add validation
f34fb8f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 27, 2024 in 0s

37.08% (-0.01%) compared to ab04192, passed because coverage increased by 0% when compared to adjusted base (37.08%)

View this Pull Request on Codecov

37.08% (-0.01%) compared to ab04192, passed because coverage increased by 0% when compared to adjusted base (37.08%)

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 37.08%. Comparing base (ab04192) to head (f34fb8f).

Files with missing lines Patch % Lines
...ytepropeller/pkg/controller/nodes/array/handler.go 52.94% 6 Missing and 2 partials ⚠️
...ler/pkg/apis/flyteworkflow/v1alpha1/node_status.go 0.00% 7 Missing ⚠️
...opeller/pkg/controller/nodes/node_state_manager.go 20.00% 4 Missing ⚠️
...lytepropeller/pkg/controller/nodes/transformers.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6054      +/-   ##
==========================================
- Coverage   37.08%   37.08%   -0.01%     
==========================================
  Files        1318     1318              
  Lines      132284   132312      +28     
==========================================
+ Hits        49062    49068       +6     
- Misses      78950    78971      +21     
- Partials     4272     4273       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov