Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monorepo] Bump components versions 1.10 #4072

Merged
merged 34 commits into from
Sep 26, 2023
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
8a548ca
Supporting using arraynode as a subnode (#606)
hamersaw Sep 7, 2023
dc0b719
Fix resources requests for AWS Batch plugin (#400)
hamersaw Sep 7, 2023
f86cd04
enable secrets in non-python k8s tasks (#401)
hamersaw Sep 11, 2023
60fc7e6
fixing boilerplate (#617)
hamersaw Sep 11, 2023
520ca11
bumped flyteplugins to v1.1.23 (#616)
hamersaw Sep 11, 2023
7f3a2cc
Expire flyte_idt cookie at logout (#610)
iaroslav-ciupin Sep 11, 2023
8c29094
start informerFactory by default. (#614)
chaohengstudent Sep 11, 2023
1d4d4b6
added check for invalid argument code on node event recording failure…
hamersaw Sep 12, 2023
7516d16
Logout hook plugin (#611)
iaroslav-ciupin Sep 12, 2023
7552324
Reduce a warning to info (#612)
wild-endeavor Sep 13, 2023
fc8afaa
Only enqueue non-terminal tasks (#164)
pingsutw Sep 14, 2023
993fe99
Make rendering template in agent client temporary (#395)
edwinyyyu Sep 14, 2023
caeaf5c
Mark webapi task failure as retry limit exceeded (#392)
pingsutw Sep 14, 2023
2536dd1
feat: Dask add pod template support (#374)
bstadlbauer Sep 18, 2023
fd8986d
Update boilerplate version (#114)
flyte-bot Sep 18, 2023
9dec0ce
Update boilerplate version (#605)
flyte-bot Sep 18, 2023
45a095e
Bump flytestdlib version (#404)
pingsutw Sep 19, 2023
35ae1b4
Create a FileOutput reader if the agent produce file output (#391)
pingsutw Sep 19, 2023
8caf7dd
Bump flytestdlib version (#619)
pingsutw Sep 19, 2023
7bd98a9
GPU Type (#419)
wild-endeavor Sep 20, 2023
965f861
[flyteidl] Support attribute access on promises (#439)
ByronHsu Sep 21, 2023
d740c7b
Add supportTaskTypes for agentservice without write it in config twic…
Future-Outlier Sep 22, 2023
d38e892
Add supportTaskTypes for agentservice without write it in config twic…
Future-Outlier Sep 22, 2023
66e7b64
Add ray dashboard log link (#405)
EngHabu Sep 23, 2023
7582ad0
Revert "GPU Type (#419)" (#444)
jeevb Sep 25, 2023
290bd1a
Merge remote-tracking branch 'eapolinario-flyteadmin/prepare-for-mono…
eapolinario Sep 26, 2023
2cb93ed
Lint flyteadmin/auth/handlers_test.go
eapolinario Sep 26, 2023
ffd88fe
Merge remote-tracking branch 'eapolinario-flytestdlib/prepare-for-mon…
eapolinario Sep 26, 2023
a218a0b
Merge remote-tracking branch 'eapolinario-flyteplugins/prepare-for-mo…
eapolinario Sep 26, 2023
e4aa181
Fix flyteplugins lint errors
eapolinario Sep 26, 2023
624d1b3
Merge remote-tracking branch 'eapolinario-flyteidl/prepare-for-monore…
eapolinario Sep 26, 2023
0879db5
Merge remote-tracking branch 'eapolinario-datacatalog/prepare-for-mon…
eapolinario Sep 26, 2023
78d83bc
Merge remote-tracking branch 'eapolinario-flytepropeller/prepare-for-…
eapolinario Sep 26, 2023
28b55a5
Fix typo in flyteplugins/go/tasks/plugins/k8s/dask/dask.go
eapolinario Sep 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added check for invalid argument code on node event recording failure…
… (#613)

Signed-off-by: Daniel Rammer <daniel@union.ai>
hamersaw authored Sep 12, 2023
commit 1d4d4b69a9c3111cce382917a28aacd1efd14556
11 changes: 7 additions & 4 deletions flytepropeller/pkg/controller/nodes/executor.go
Original file line number Diff line number Diff line change
@@ -1230,10 +1230,13 @@ func (c *nodeExecutor) handleQueuedOrRunningNode(ctx context.Context, nCtx inter

err = nCtx.EventsRecorder().RecordNodeEvent(ctx, nev, c.eventConfig)
if err != nil {
if eventsErr.IsTooLarge(err) {
// With large enough dynamic task fanouts the reported node event, which contains the compiled
// workflow closure, can exceed the gRPC message size limit. In this case we immediately
// transition the node to failing to abort the workflow.
if eventsErr.IsTooLarge(err) || eventsErr.IsInvalidArguments(err) {
// we immediately transition to failing if one of two scenarios occur during node event recording:
// (1) the event is too large to be sent over gRPC. this can occur if, for example, a dynamic task
// has a very large fanout and the compiled workflow closure causes the event to exceed the gRPC
// message size limit.
// (2) the event is invalid. this can occur if, for example, a dynamic task compiles a workflow
// which is invalid per admin limits (ex. maximum resources exceeded).
np = v1alpha1.NodePhaseFailing
p = handler.PhaseInfoFailure(core.ExecutionError_USER, "NodeFailed", err.Error(), p.GetInfo())