Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] github.com/flyteorg/flyte/flytectl/cmd/sandbox unit test is flaky #5937

Closed
2 tasks done
Sovietaced opened this issue Oct 29, 2024 · 3 comments · Fixed by #5950
Closed
2 tasks done

[BUG] github.com/flyteorg/flyte/flytectl/cmd/sandbox unit test is flaky #5937

Sovietaced opened this issue Oct 29, 2024 · 3 comments · Fixed by #5950
Assignees
Labels
bug Something isn't working

Comments

@Sovietaced
Copy link
Contributor

Describe the bug

Its not clear why but this unit test seems to flake when running on CI.

FAIL	github.com/flyteorg/flyte/flytectl/cmd/sandbox	0.086s

https://github.com/flyteorg/flyte/actions/runs/11580285322/job/32238460143?pr=5814

Expected behavior

I expect the unit test to pass.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Sovietaced Sovietaced added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Oct 29, 2024
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Oct 31, 2024
@eapolinario eapolinario self-assigned this Oct 31, 2024
@nkwangleiGIT
Copy link

seems this testcase was successful at the latest attempt, it's not clear why it failed here, and not able to reproduce it locally.
do we have any log to check for the root cause in the CI? or we can add one for later investigation.

@Sovietaced
Copy link
Contributor Author

seems this testcase was successful at the latest attempt, it's not clear why it failed here, and not able to reproduce it locally.

do we have any log to check for the root cause in the CI? or we can add one for later investigation.

I don't but I have a hunch the flakiness is related to transient issues with the docker calls and the GitHub runner.

@eapolinario
Copy link
Contributor

This is related to #5325 in that that PR didn't replace all instances of the testutils.Setup with the corresponding teardown.

Here's a PR with the fix: #5950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
3 participants